netdev - Re: [PATCH net-next v3 3/3] tsnep: Add TSN endpoint Ethernet MAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANr-f5yBuKd0D4xppyRm+PUmLredFuGA=dM_BSQ9VkSPTfX2Lw@mail.gmail.com>
Date:   Sat, 30 Oct 2021 09:12:30 +0200
From:   Gerhard Engleder <gerhard@...leder-embedded.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Miller <davem@...emloft.net>, Andrew Lunn <andrew@...n.ch>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v3 3/3] tsnep: Add TSN endpoint Ethernet MAC driver

On Sat, Oct 30, 2021 at 6:27 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Fri, 29 Oct 2021 22:07:42 +0200 Gerhard Engleder wrote:
> > The TSN endpoint Ethernet MAC is a FPGA based network device for
> > real-time communication.
> >
> > It is integrated as Ethernet controller with ethtool and PTP support.
> > For real-time communcation TC_SETUP_QDISC_TAPRIO is supported.
> >
> > Signed-off-by: Gerhard Engleder <gerhard@...leder-embedded.com>
>
> Looks like there is a lot of sparse warnings about endian.
> Please make sure it builds cleanly with W=1 C=1 and repost.

Thank you for the hint! I have not known sparse until now. I'm now using
sparse v0.6.4 and I got warnings about missing __iomem and fixed them.
But there were no endian warnings. I used the following command line:

make M=drivers/net/ethernet/engleder/ W=1 C=1

About endian: I have not considered endian so far, as this driver is used
only for x86 and arm64. Is that ok?

Gerhard