netdev - Re: [PATCH net-next v5 4/5] amt: add mld report message handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202110312141.4F6qnLd5-lkp@intel.com>
Date:   Sun, 31 Oct 2021 21:04:21 +0800
From:   kernel test robot <lkp@...el.com>
To:     Taehee Yoo <ap420073@...il.com>, davem@...emloft.net,
        kuba@...nel.org, dsahern@...nel.org, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, dkirjanov@...e.de, ap420073@...il.com
Subject: Re: [PATCH net-next v5 4/5] amt: add mld report message handler

Hi Taehee,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Taehee-Yoo/amt-add-initial-driver-for-Automatic-Multicast-Tunneling-AMT/20211030-204039
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git ae0393500e3b0139210749d52d22b29002c20e16
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/d571c3adc1fb02877f7bc3f1c6cf3b1f740c1bc2
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Taehee-Yoo/amt-add-initial-driver-for-Automatic-Multicast-Tunneling-AMT/20211030-204039
        git checkout d571c3adc1fb02877f7bc3f1c6cf3b1f740c1bc2
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/net/amt.c: In function 'amt_build_mld_gq':
>> drivers/net/amt.c:873:30: error: implicit declaration of function 'csum_ipv6_magic'; did you mean 'csum_tcpudp_magic'? [-Werror=implicit-function-declaration]
     873 |         mld2q->mld2q_cksum = csum_ipv6_magic(&ip6h->saddr, &ip6h->daddr,
         |                              ^~~~~~~~~~~~~~~
         |                              csum_tcpudp_magic
   cc1: all warnings being treated as errors


vim +873 drivers/net/amt.c

   810	
   811	#if IS_ENABLED(CONFIG_IPV6)
   812	static struct sk_buff *amt_build_mld_gq(struct amt_dev *amt)
   813	{
   814		u8 ra[AMT_IP6HDR_OPTS] = { IPPROTO_ICMPV6, 0, IPV6_TLV_ROUTERALERT,
   815					   2, 0, 0, IPV6_TLV_PAD1, IPV6_TLV_PAD1 };
   816		int hlen = LL_RESERVED_SPACE(amt->dev);
   817		int tlen = amt->dev->needed_tailroom;
   818		struct mld2_query *mld2q;
   819		void *csum_start = NULL;
   820		struct ipv6hdr *ip6h;
   821		struct sk_buff *skb;
   822		struct ethhdr *eth;
   823		u32 len;
   824	
   825		len = hlen + tlen + sizeof(*ip6h) + sizeof(ra) + sizeof(*mld2q);
   826		skb = netdev_alloc_skb_ip_align(amt->dev, len);
   827		if (!skb)
   828			return NULL;
   829	
   830		skb_reserve(skb, hlen);
   831		skb_push(skb, sizeof(*eth));
   832		skb_reset_mac_header(skb);
   833		eth = eth_hdr(skb);
   834		skb->priority = TC_PRIO_CONTROL;
   835		skb->protocol = htons(ETH_P_IPV6);
   836		skb_put_zero(skb, sizeof(*ip6h));
   837		skb_put_data(skb, ra, sizeof(ra));
   838		skb_put_zero(skb, sizeof(*mld2q));
   839		skb_pull(skb, sizeof(*eth));
   840		skb_reset_network_header(skb);
   841		ip6h			= ipv6_hdr(skb);
   842		ip6h->payload_len	= htons(sizeof(ra) + sizeof(*mld2q));
   843		ip6h->nexthdr		= NEXTHDR_HOP;
   844		ip6h->hop_limit		= 1;
   845		ip6h->daddr		= mld2_all_node;
   846		ip6_flow_hdr(ip6h, 0, 0);
   847	
   848		if (ipv6_dev_get_saddr(amt->net, amt->dev, &ip6h->daddr, 0,
   849				       &ip6h->saddr)) {
   850			amt->dev->stats.tx_errors++;
   851			kfree_skb(skb);
   852			return NULL;
   853		}
   854	
   855		eth->h_proto = htons(ETH_P_IPV6);
   856		ether_addr_copy(eth->h_source, amt->dev->dev_addr);
   857		ipv6_eth_mc_map(&mld2_all_node, eth->h_dest);
   858	
   859		skb_pull(skb, sizeof(*ip6h) + sizeof(ra));
   860		skb_reset_transport_header(skb);
   861		mld2q			= (struct mld2_query *)icmp6_hdr(skb);
   862		mld2q->mld2q_mrc	= htons(1);
   863		mld2q->mld2q_type	= ICMPV6_MGM_QUERY;
   864		mld2q->mld2q_code	= 0;
   865		mld2q->mld2q_cksum	= 0;
   866		mld2q->mld2q_resv1	= 0;
   867		mld2q->mld2q_resv2	= 0;
   868		mld2q->mld2q_suppress	= 0;
   869		mld2q->mld2q_qrv	= amt->qrv;
   870		mld2q->mld2q_nsrcs	= 0;
   871		mld2q->mld2q_qqic	= amt->qi;
   872		csum_start		= (void *)mld2q;
 > 873		mld2q->mld2q_cksum = csum_ipv6_magic(&ip6h->saddr, &ip6h->daddr,
   874						     sizeof(*mld2q),
   875						     IPPROTO_ICMPV6,
   876						     csum_partial(csum_start,
   877								  sizeof(*mld2q), 0));
   878	
   879		skb->ip_summed = CHECKSUM_NONE;
   880		skb_push(skb, sizeof(*eth) + sizeof(*ip6h) + sizeof(ra));
   881		return skb;
   882	}
   883	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (61087 bytes)