netdev - Re: [PATHC bpf v6 1/3] skmsg: lose offset info in sk_psock_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 01 Nov 2021 16:20:08 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Liu Jian <liujian56@...wei.com>
Cc:     john.fastabend@...il.com, daniel@...earbox.net,
        jakub@...udflare.com, lmb@...udflare.com, davem@...emloft.net,
        kuba@...nel.org, ast@...nel.org, andrii@...nel.org, kafai@...com,
        songliubraving@...com, yhs@...com, kpsingh@...nel.org,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        xiyou.wangcong@...il.com, alexei.starovoitov@...il.com
Subject: Re: [PATHC bpf v6 1/3] skmsg: lose offset info in sk_psock_skb_ingress

Hello:

This series was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@...earbox.net>:

On Fri, 29 Oct 2021 22:12:14 +0800 you wrote:
> If sockmap enable strparser, there are lose offset info in
> sk_psock_skb_ingress. If the length determined by parse_msg function
> is not skb->len, the skb will be converted to sk_msg multiple times,
> and userspace app will get the data multiple times.
> 
> Fix this by get the offset and length from strp_msg.
> And as Cong suggestion, add one bit in skb->_sk_redir to distinguish
> enable or disable strparser.
> 
> [...]

Here is the summary with links:
  - [PATHC,bpf,v6,1/3] skmsg: lose offset info in sk_psock_skb_ingress
    https://git.kernel.org/bpf/bpf-next/c/7303524e04af
  - [PATHC,bpf,v6,2/3] selftests, bpf: Fix test_txmsg_ingress_parser error
    https://git.kernel.org/bpf/bpf-next/c/b556c3fd4676
  - [PATHC,bpf,v6,3/3] selftests, bpf: Add one test for sockmap with strparser
    https://git.kernel.org/bpf/bpf-next/c/d69672147faa

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html