netdev - Re: [PATCH net-next v3 3/3] tsnep: Add TSN endpoint Ethernet MAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANr-f5z-Mg9GbegqFPrk-uHExmXvh8Xq4N_S0UzNbdEVBf9+HQ@mail.gmail.com>
Date:   Mon, 1 Nov 2021 21:29:37 +0100
From:   Gerhard Engleder <gerhard@...leder-embedded.com>
To:     Andrew Lunn <andrew@...n.ch>, Jakub Kicinski <kuba@...nel.org>
Cc:     David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v3 3/3] tsnep: Add TSN endpoint Ethernet MAC driver

> > About endian: I have not considered endian so far, as this driver is used
> > only for x86 and arm64. Is that ok?
>
> In most cases, there is little you need to do, so long as you use the
> correct methods to access the bus. PCI registers are always little
> endian for example, so easy to handle. Memory mapped structures are
> where you need to be careful, your receive and transmit descriptors.
> You need to use the correct __le32 or __be32 annotation, and then
> sparse will warn you if you access them without the needed conversion.

Thanks! Now I get those warnings. I'll fix them.

Gerhard