netdev - Re: [PATCH net 4/5] kselftests/net: add missed toeplitz.sh/toeplitz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+FuTSesPTGL7B9MOGgb_9Xni9ni_1pDeS+Dm9=vUu1j6GT_qg@mail.gmail.com>
Date:   Mon, 1 Nov 2021 19:02:14 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Andrea Mayer <andrea.mayer@...roma2.it>,
        Coco Li <lixiaoyan@...gle.com>,
        Paolo Lungaroni <paolo.lungaroni@...roma2.it>,
        Paolo Abeni <pabeni@...hat.com>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net 4/5] kselftests/net: add missed toeplitz.sh/toeplitz_client.sh
 to Makefile

On Mon, Nov 1, 2021 at 12:06 AM Hangbin Liu <liuhangbin@...il.com> wrote:
>
> When generating the selftests to another folder, the toeplitz.sh
> and toeplitz_client.sh are missing as they are not in Makefile, e.g.
>
>   make -C tools/testing/selftests/ install \
>       TARGETS="net" INSTALL_PATH=/tmp/kselftests
>
> Fixes: 5ebfb4cc3048 ("selftests/net: toeplitz test")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  tools/testing/selftests/net/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
> index 8a6264da5276..514bbed80e68 100644
> --- a/tools/testing/selftests/net/Makefile
> +++ b/tools/testing/selftests/net/Makefile
> @@ -31,7 +31,9 @@ TEST_PROGS += gre_gso.sh
>  TEST_PROGS += srv6_end_dt46_l3vpn_test.sh
>  TEST_PROGS += srv6_end_dt4_l3vpn_test.sh
>  TEST_PROGS += srv6_end_dt6_l3vpn_test.sh
> +TEST_PROGS += toeplitz.sh
>  TEST_PROGS_EXTENDED := in_netns.sh setup_loopback.sh setup_veth.sh
> +TEST_PROGS_EXTENDED += toeplitz_client.sh

Thanks for adding the files. They are indeed missing.

But they are not intended to be run from kselftests, as this tests nic
hardware features. So both files should be under TEST_PROGS_EXTENDED?