netdev - Re: [PATCHv2 net 5/5] kselftests/net: add missed toeplitz.sh/toeplitz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Nov 2021 11:09:43 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Andrea Mayer <andrea.mayer@...roma2.it>,
        Coco Li <lixiaoyan@...gle.com>,
        Paolo Lungaroni <paolo.lungaroni@...roma2.it>,
        Paolo Abeni <pabeni@...hat.com>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        linux-kselftest@...r.kernel.org,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>
Subject: Re: [PATCHv2 net 5/5] kselftests/net: add missed toeplitz.sh/toeplitz_client.sh
 to Makefile

On Mon, Nov 1, 2021 at 9:37 PM Hangbin Liu <liuhangbin@...il.com> wrote:
>
> When generating the selftests to another folder, the toeplitz.sh
> and toeplitz_client.sh are missing as they are not in Makefile, e.g.
>
>   make -C tools/testing/selftests/ install \
>       TARGETS="net" INSTALL_PATH=/tmp/kselftests
>
> Making them under TEST_PROGS_EXTENDED as they test NIC hardware features
> and are not intended to be run from kselftests.
>
> Fixes: 5ebfb4cc3048 ("selftests/net: toeplitz test")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>

The same might apply to the icmp and vrf tests? I am not familiar with those.