netdev - Re: [PATCH v2] tcp: Use BPF timeout setting for SYN ACK RTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <5C1E4FAF-7A28-40F2-8E67-4B352ED5F45E@yandex-team.ru>
Date:   Tue, 02 Nov 2021 22:13:24 +0300
From:   Ахмат Каракотов 
        <hmukos@...dex-team.ru>
To:     Yuchung Cheng <ycheng@...gle.com>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        Lawrence Brakmo <brakmo@...com>,
        Alexander Azimov <mitradir@...dex-team.ru>,
        Neal Cardwell <ncardwell@...gle.com>, netdev@...r.kernel.org,
        zeil@...dex-team.ru
Subject: Re: [PATCH v2] tcp: Use BPF timeout setting for SYN ACK RTO

> On Nov 2, 2021, at 21:57, Yuchung Cheng <ycheng@...gle.com> wrote:
>
>> static inline struct request_sock *inet_reqsk(const struct sock *sk)
>> @@ -104,6 +105,7 @@ reqsk_alloc(const struct request_sock_ops *ops, struct sock *sk_listener,
>> sk_node_init(&req_to_sk(req)->sk_node);
>> sk_tx_queue_clear(req_to_sk(req));
>> req->saved_syn = NULL;
>> + req->timeout = 0;
>
> why not just set to TCP_TIMEOUT_INIT to avoid setting it again in
> inet_reqsk_alloc?
>

I tried, however net/request_sock.h does not include net/tcp.h and
after trying to include it I got lots of errors. So I thought that
request_sock is not supposed to know anything about TCP. If I'm
wrong than what would be the best way to reference this constant?
Should I just redefine it in net/request_sock.h?