[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <YYKZ/a11TEs48+Xb@smile.fi.intel.com>
Date: Wed, 3 Nov 2021 16:17:33 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Jonas Dreßler <verdre@...d.nl>
Cc: Amitkumar Karwar <amitkarwar@...il.com>,
Ganapathi Bhat <ganapathi017@...il.com>,
Xinming Hu <huxinming820@...il.com>,
Kalle Valo <kvalo@...eaurora.org>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Tsuchiya Yuto <kitakar@...il.com>,
linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
Maximilian Luz <luzmaximilian@...il.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Pali Rohár <pali@...nel.org>
Subject: Re: [PATCH v2 1/2] mwifiex: Use a define for firmware version string
length
On Wed, Nov 03, 2021 at 02:55:28PM +0100, Jonas Dreßler wrote:
> Since the version string we get from the firmware is always 128
> characters long, use a define for this size instead of having the number
> 128 copied all over the place.
Just answered to the previous one :-) Okay, you may ignore that thread
since you did what you and I were talking about.
...
> + sizeof(char) * MWIFIEX_VERSION_STR_LENGTH);
While at it, drop the redundant sizeof().
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists