[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5a74137a-97ee-711d-97a2-105b0dd92cee@squareup.com>
Date: Wed, 3 Nov 2021 10:01:13 -0700
From: Benjamin Li <benl@...areup.com>
To: Loic Poulain <loic.poulain@...aro.org>
Cc: Kalle Valo <kvalo@...eaurora.org>,
Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
linux-arm-msm@...r.kernel.org,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>, wcn36xx@...ts.infradead.org,
linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] wcn36xx: fix RX BD rate mapping for 5GHz legacy
rates
On 11/3/21 10:08 AM, Loic Poulain wrote:
> Hi Ben,
>
> It looks fine, but can you replace it with a 'status.rate_idx >= 4'.
> I get sporadic 5Ghz frames reported with rate_idx=0 (firmware miss?),
> leading to warnings because status.rate_idx is -4(unsigned) in that
> case. So better to report a wrong rate than a corrupted one.
>
Thanks for confirming that. Will send v3 that just falls-through on
rate_idx < 4, no warn or log.
Ben
>
>
> Regards,
> Loic
>
Powered by blists - more mailing lists