netdev - RE: [net-next PATCH v5] net: macb: Fix several edge cases in validate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY4PR07MB27576B46D37E39F9F1789A31C18C9@CY4PR07MB2757.namprd07.prod.outlook.com>
Date:   Wed, 3 Nov 2021 10:14:33 +0000
From:   Parshuram Raju Thombare <pthombar@...ence.com>
To:     Sean Anderson <sean.anderson@...o.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
CC:     Milind Parab <mparab@...ence.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Antoine Tenart <atenart@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>
Subject: RE: [net-next PATCH v5] net: macb: Fix several edge cases in validate

Hi Sean,

Thanks for this improvement.

>+	if (!macb_is_gem(bp) ||
>+	    (bp->caps & MACB_CAPS_GIGABIT_MODE_AVAILABLE)) {
>+		have_1g = true;
>+		if (bp->caps & MACB_CAPS_PCS)
>+			have_sgmii = true;
>+		if (bp->caps & MACB_CAPS_HIGH_SPEED)
>+			have_10g = true;

As I understand, MACB_CAPS_GIGABIT_MODE_AVAILABLE is used as a quirk in configs
to prevent giga bit operation support, Nicolas should have more information about this.

macb_is_gem() tells whether giga bit operations is supported by HW, MACB_CAPS_PCS indicate
whether PCS is included in the design (needed for SGMII and 10G operation), MACB_CAPS_HIGH_SPEED
indicate if design supports 10G operation.

I believe this should be

>+	if (macb_is_gem(bp) &&
>+	    (bp->caps & MACB_CAPS_GIGABIT_MODE_AVAILABLE)) {
>+		have_1g = true;
>+		if (bp->caps & MACB_CAPS_PCS)
>+			have_sgmii = true;
>+		if (bp->caps & MACB_CAPS_HIGH_SPEED)
>+			have_10g = true;

Regards,
Parshuram Thombare