[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5305c72d-e8f0-c4cd-3a85-2f12a0f644c8@microchip.com>
Date: Thu, 4 Nov 2021 16:15:53 +0100
From: Nicolas Ferre <nicolas.ferre@...rochip.com>
To: Parshuram Raju Thombare <pthombar@...ence.com>,
Sean Anderson <sean.anderson@...o.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"David S . Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>
CC: Milind Parab <mparab@...ence.com>,
Claudiu Beznea <claudiu.beznea@...rochip.com>,
Antoine Tenart <atenart@...nel.org>,
"Russell King" <linux@...linux.org.uk>
Subject: Re: [net-next PATCH v5] net: macb: Fix several edge cases in validate
On 03/11/2021 at 11:14, Parshuram Raju Thombare wrote:
> Hi Sean,
>
> Thanks for this improvement.
>
>> + if (!macb_is_gem(bp) ||
>> + (bp->caps & MACB_CAPS_GIGABIT_MODE_AVAILABLE)) {
>> + have_1g = true;
>> + if (bp->caps & MACB_CAPS_PCS)
>> + have_sgmii = true;
>> + if (bp->caps & MACB_CAPS_HIGH_SPEED)
>> + have_10g = true;
>
> As I understand, MACB_CAPS_GIGABIT_MODE_AVAILABLE is used as a quirk in configs
> to prevent giga bit operation support, Nicolas should have more information about this.
That's right Parshuram.
> macb_is_gem() tells whether giga bit operations is supported by HW, MACB_CAPS_PCS indicate
> whether PCS is included in the design (needed for SGMII and 10G operation), MACB_CAPS_HIGH_SPEED
> indicate if design supports 10G operation.
>
> I believe this should be
>
>> + if (macb_is_gem(bp) &&
>> + (bp->caps & MACB_CAPS_GIGABIT_MODE_AVAILABLE)) {
>> + have_1g = true;
>> + if (bp->caps & MACB_CAPS_PCS)
>> + have_sgmii = true;
>> + if (bp->caps & MACB_CAPS_HIGH_SPEED)
>> + have_10g = true;
Regards,
Nicolas
--
Nicolas Ferre
Powered by blists - more mailing lists