netdev - Re: [RFC net-next/wireless-next v1 2/2] ath10k: move device_get_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 4 Nov 2021 16:51:03 +0100
From:   Christian Lamparter <chunkeey@...il.com>
To:     Mathias Kresin <dev@...sin.me>, netdev@...r.kernel.org,
        linux-acpi@...r.kernel.org, linux-wireless@...r.kernel.org,
        ath10k@...ts.infradead.org
Cc:     Ansuel Smith <ansuelsmth@...il.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S . Miller" <davem@...emloft.net>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>, Len Brown <lenb@...nel.org>,
        Andrew Lunn <andrew@...n.ch>, Michael Walle <michael@...le.cc>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [RFC net-next/wireless-next v1 2/2] ath10k: move
 device_get_mac_address() and pass errors up the chain

Hi Mathias,

On 02/11/2021 23:08, Mathias Kresin wrote:
> 10/30/21 7:41 PM, Christian Lamparter:
>> --- a/drivers/net/wireless/ath/ath10k/ahb.c
>> +++ b/drivers/net/wireless/ath/ath10k/ahb.c
>> @@ -745,9 +745,11 @@ static int ath10k_ahb_probe(struct platform_device *pdev)
>>       size = sizeof(*ar_pci) + sizeof(*ar_ahb);
>>       ar = ath10k_core_create(size, &pdev->dev, ATH10K_BUS_AHB,
>>                   hw_rev, &ath10k_ahb_hif_ops);
>> -    if (!ar) {
>> -        dev_err(&pdev->dev, "failed to allocate core\n");
>> -        return -ENOMEM;
>> +    if (IS_ERR(ar)) {
>> +        ret = PTR_ERR(ar);
>> +        if (ret != -EPROBE_DEFER)
>> +            dev_err(&pdev->dev, "failed to allocate core: %d\n", ret);
> 
> There's a helper for that: dev_err_probe().

I was looking for that. Thank you! :-)
(I need to check if this device_get_mac_address() all works
with 5.15-next or not. It's probably easier to wait until
5.16-rc1-wt gets released).

Regards,
Christian