netdev - [PATCH v2] ipv4: Remove useless assignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20211104030222.30580-1-luo.penghao@zte.com.cn>
Date:   Thu,  4 Nov 2021 03:02:22 +0000
From:   cgel.zte@...il.com
To:     "David S . Miller" <davem@...emloft.net>
Cc:     Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, luo penghao <luo.penghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: [PATCH v2] ipv4: Remove useless assignments

From: luo penghao <luo.penghao@....com.cn>

From: luo penghao <luo.penghao@....com.cn>

The assigned local variables will not be used next, so this statement
should be deleted.

The clang_analyzer complains as follows:

net/ipv4/ipconfig.c:1037:2 warning:

Value stored to 'h' is never read

Changes in v2:

Repair sending email box

Reported-by: Zeal Robot <zealci@....com.cn>
Signed-off-by: luo penghao <luo.penghao@....com.cn>
---
 net/ipv4/ipconfig.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index 816d8aa..fe2c8e9 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -1034,7 +1034,6 @@ static int __init ic_bootp_recv(struct sk_buff *skb, struct net_device *dev, str
 		goto drop;
 
 	b = (struct bootp_pkt *)skb_network_header(skb);
-	h = &b->iph;
 
 	/* One reply at a time, please. */
 	spin_lock(&ic_recv_lock);
-- 
2.15.2