netdev - Re: [PATCH net] net: dsa: mv88e6xxx: Don't support >1G speeds on 6191X on ports other than 10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211104195828.199c58b9@thinkpad>
Date:   Thu, 4 Nov 2021 19:58:28 +0100
From:   Marek Behún <kabel@...nel.org>
To:     "Russell King (Oracle)" <linux@...linux.org.uk>
Cc:     netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Don't support >1G speeds on
 6191X on ports other than 10

On Thu, 4 Nov 2021 18:15:57 +0000
"Russell King (Oracle)" <linux@...linux.org.uk> wrote:

> On Thu, Nov 04, 2021 at 06:17:47PM +0100, Marek Behún wrote:
> > Model 88E6191X only supports >1G speeds on port 10. Port 0 and 9 are
> > only 1G.  
> 
> Interesting. The original commit says:
> 
> SERDESes can do USXGMII, 10GBASER and 5GBASER (on 6191X only one
> SERDES is capable of more than 1g; USXGMII is not yet supported
> with this change)
> 
> which is ambiguously worded - so I guess we now know that it's only
> port 10 that supports speeds above 1G.

Yes, I just found this info in datasheet.

> Can ports 0 / 1 / 10 be changed at runtime (iow, is the C_Mode field
> writable on these ports?)

Yes, cmode is writable on these ports. serdes.c also provides some
errata fixes when changing cmode.

(BTW Russell I have already updated your patch
   net: dsa: mv88e6xxx: populate supported_interfaces
 from your net-queue branch.
 I am rebasing your work on top of net-next and also adding some other
 stuff. I will send you the patches later.)

Marek