netdev - RE: [PATCH 2/2] net: ethernet: Add driver for Sunplus SP7021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72446c510f05480f9967c32df8787d46@sphcmbx02.sunplus.com.tw>
Date:   Thu, 4 Nov 2021 19:03:43 +0000
From:   Wells Lu 呂芳騰 <wells.lu@...plus.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     Randy Dunlap <rdunlap@...radead.org>,
        Wells Lu <wellslutw@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>
Subject: RE: [PATCH 2/2] net: ethernet: Add driver for Sunplus SP7021

> > No, we only develop arm-based SoC, never for x86 or mips.
> > We never compile the driver for x86 or mips machine.
> 
> You don't, but the Linux community does build for those architectures. Most
> people do tree wide refactoring work using x86. Tree wide cleanups using x86,
> etc. Any changes like that could touch your driver. The harder is it to build, the
> less build testing it will get, and tree wide changes which break it are less likely
> to get noticed.  So you really do want it to compile cleanly for all
> architectures. If it does not, it normally actually means you are doing
> something wrong, something you need to fix anyway. So please do build it for
> x86 and make sure it builds cleanly.
> 
> 	  Andrew

Ok, I understand.
I'll add COMPILE_TEST and compile driver for x86.

Thanks,