netdev - Re: [PATCH net-next v2 0/2] MCTP sockaddr padding check/initialisation fixup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54b02f37ab63e0e5a0c6fc2912b8652927fdb22f.camel@codeconstruct.com.au>
Date:   Fri, 05 Nov 2021 07:59:17 +0800
From:   Jeremy Kerr <jk@...econstruct.com.au>
To:     Jakub Kicinski <kuba@...nel.org>,
        Eugene Syromiatnikov <esyr@...hat.com>
Cc:     Matt Johnston <matt@...econstruct.com.au>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 0/2] MCTP sockaddr padding
 check/initialisation fixup

Hi Jakub,

> > This pair of patches introduces checks for padding fields of struct
> > sockaddr_mctp/sockaddr_mctp_ext to ease their re-use for possible
> > extensions in the future;  as well as zeroing of these fields
> > in the respective sockaddr filling routines.  While the first
> > commit
> > is definitely an ABI breakage, it is proposed in hopes that the
> > change
> > is made soon enough (the interface appeared only in Linux 5.15)
> > to avoid affecting any existing user space.
> 
> Seems reasonable, Jeremy can you send an ack?

Yep, will do ASAP - I'm planning also send references to the commits
ton the userspace side, so that we have a record of where everything
lines up on the updated ABI.

I'll have that done later today.

Cheers,


Jeremy