lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 5 Nov 2021 17:33:55 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Chengfeng Ye <cyeaa@...nect.ust.hk> Cc: krzysztof.kozlowski@...onical.com, davem@...emloft.net, kuba@...nel.org, wengjianfeng@...ong.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] nfc: pn533: Fix double free when pn533_fill_fragment_skbs() fails On Fri, Nov 05, 2021 at 06:36:36AM -0700, Chengfeng Ye wrote: > skb is already freed by dev_kfree_skb in pn533_fill_fragment_skbs, > but follow error handler branch when pn533_fill_fragment_skbs() > fails, skb is freed again, results in double free issue. Fix this > by not free skb in error path of pn533_fill_fragment_skbs. > > Signed-off-by: Chengfeng Ye <cyeaa@...nect.ust.hk> I sort of wish the commit message talked more about the how this changes the failure return from 0 to -ENOMEM. But the patch is good. Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com> regards, dan carpenter
Powered by blists - more mailing lists