netdev - Re: [PATCH bpf 0/4] Fix some issues for selftest test_xdp_redirect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3257169-b252-9446-1893-08ef9d1f9bcf@iogearbox.net>
Date:   Fri, 5 Nov 2021 16:46:45 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc:     bpf@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        linux-kselftest@...r.kernel.org,
        "David S . Miller" <davem@...emloft.net>,
        Jiri Benc <jbenc@...hat.com>
Subject: Re: [PATCH bpf 0/4] Fix some issues for selftest
 test_xdp_redirect_multi.sh

On 10/27/21 5:35 AM, Hangbin Liu wrote:
> Jiri reported some issues in test_xdp_redirect_multi.sh. Like
> the test logs not cleaned after testing. The tcpdump not terminated cleanly.
> arp number count may have false positive. And the most important, after
> creating/deleting a lot interfaces, the interface index may exceed the
> DEVMAP max entry and cause program xdp_redirect_multi exec failed.
> 
> This patch set fix all these issues.
> 
> Hangbin Liu (4):
>    selftests/bpf/xdp_redirect_multi: put the logs to tmp folder
>    selftests/bpf/xdp_redirect_multi: use arping to accurate the arp
>      number
>    selftests/bpf/xdp_redirect_multi: give tcpdump a chance to terminate
>      cleanly
>    selftests/bpf/xdp_redirect_multi: limit the tests in netns
> 
>   .../selftests/bpf/test_xdp_redirect_multi.sh  | 62 +++++++++++--------
>   .../selftests/bpf/xdp_redirect_multi.c        |  4 +-
>   2 files changed, 37 insertions(+), 29 deletions(-)

Applied, thanks, been fixing up a small merge conflict in the last one due to
8fffa0e3451ab ("selftests/bpf: Normalize XDP section names in selftests"), pls
double check.