netdev - Re: [PATCH net v4] net: marvell: prestera: fix hw structure laid out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 6 Nov 2021 10:54:11 +0000
From:   Volodymyr Mytnyk <volodymyr.mytnyk@...ision.eu>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Guenter Roeck <linux@...ck-us.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Taras Chornyi <taras.chornyi@...ision.eu>,
        Mickey Rachamim <mickeyr@...vell.com>,
        Serhiy Pshyk <serhiy.pshyk@...ision.eu>,
        Andrew Lunn <andrew@...n.ch>, Arnd Bergmann <arnd@...db.de>,
        Denis Kirjanov <dkirjanov@...e.de>,
        Volodymyr Mytnyk <vmytnyk@...vell.com>,
        Taras Chornyi <tchornyi@...vell.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Vadym Kochan <vkochan@...vell.com>,
        Yevhen Orlov <yevhen.orlov@...ision.eu>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net v4] net: marvell: prestera: fix hw structure laid out

> On Fri, Nov 5, 2021 at 11:42 PM Volodymyr Mytnyk
> <volodymyr.mytnyk@...ision.eu> wrote:
> > > > From: Volodymyr Mytnyk <vmytnyk@...vell.com>
> > > >
> > > > The prestera FW v4.0 support commit has been merged
> > > > accidentally w/o review comments addressed and waiting
> > > > for the final patch set to be uploaded. So, fix the remaining
> > > > comments related to structure laid out and build issues.
> > > >
> > > > Reported-by: kernel test robot <lkp@...el.com>
> > > > Fixes: bb5dbf2cc64d ("net: marvell: prestera: add firmware v4.0 support")
> > > > Signed-off-by: Volodymyr Mytnyk <vmytnyk@...vell.com>
> > >
> > > The patch does not apply to the mainline kernel, so I can not test it there.
> > > It does apply to linux-next, and m68k:allmodconfig builds there with the patch
> > > applied. However, m68k:allmodconfig also builds in -next with this patch _not_
> > > applied, so I can not really say if it does any good or bad.
> > > In the meantime, the mainline kernel (as of v5.15-10643-gfe91c4725aee)
> > > still fails to build.
> 
> >         The mainline kernel doesn't have the base ("net: marvell: prestera: add firmware v4.0 support") commit yet, so the patch will not be applied.
> 
> Mainline has this broken commit as of Nov 2.

Hi Geert,

	Right, this one is it there. My fault, thx.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/ethernet/marvell/prestera/prestera_hw.c?id=bb5dbf2cc64d5cfa696765944c784c0010c48ae8
	
So, only 236f57fe1b88 ("net: marvell: prestera: Add explicit padding") from net/master is needed to fix the build and to be able to apply this patch.

Sorry for confusion.

    Volodymyr

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds