netdev - Re: [PATCH] phy: phy_ethtool_ksettings_set: Don't discard phy_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Nov 2021 15:21:45 +0100
From:   Bastian Germann <bage@...utronix.de>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>, davem@...emloft.net,
        netdev@...r.kernel.org,
        Benedikt Spranger <b.spranger@...utronix.de>
Subject: Re: [PATCH] phy: phy_ethtool_ksettings_set: Don't discard
 phy_start_aneg's return

Am 05.11.21 um 19:32 schrieb Andrew Lunn:
> What PHY driver are you using this with? phy_start_aneg() generally
> does not return errors, except for -EIO/-TIMEDOUT because
> communication with the PHY has failed. All parameter validation should
> of already happened before the call to phy_start_aneg(). So i'm
> wondering if the PHY driver is doing something wrong.

I am modifying broadcom phy and will make sure that I will end up nut having
error checks in the wrong place.