netdev - Re: [PATCH] net: mvpp2: fix XDP rx queues registering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 9 Nov 2021 17:01:24 +0000
From:   Emmanuel Deloget <emmanuel.deloget@....link>
To:     Marcin Wojtas <mw@...ihalf.com>, Louis Amas <louis.amas@....link>
CC:     Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        KP Singh <kpsingh@...nel.org>, netdev <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>
Subject: Re: [PATCH] net: mvpp2: fix XDP rx queues registering

Hello, 

From: Marcin Wojtas <mw@...ihalf.com>
> wt., 9 lis 2021 o 11:31 Louis Amas <louis.amas@....link> napisał(a):
> 
> Thank you for the patch and the detailed explanation. I think "Fixes:"
> tag should be added to the commit message:
> Fixes: b27db2274ba8 ("mvpp2: use page_pool allocator")
> 
> Other than that - LGTM, so you can add my:
> Reviewed-by: Marcin Wojtas <mw@...ihalf.com>
> 
> Best regards,
> Marcin

Thank you :)

We'll send an augmented version tomorrow along with a small rework of the commit message. 

Best regards, 

-- Emmanuel Deloget