netdev - Re: [PATCH net v9 3/3] net/8390: apne.c - add 100 Mbit support to apne.c driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 Nov 2021 08:39:34 +1300
From:   Michael Schmitz <schmitzmic@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-m68k@...r.kernel.org,
        geert@...ux-m68k.org
Cc:     alex@...ik.de, netdev@...r.kernel.org
Subject: Re: [PATCH net v9 3/3] net/8390: apne.c - add 100 Mbit support to
 apne.c driver

Geert,

On 10/11/21 08:25, Randy Dunlap wrote:
>>>>> There are no other drivers that "select PCCARD" or
>>>>> "select PCMCIA" in the entire kernel tree.
>>>>> I don't see any good justification to allow it here.
>>>>
>>>> Amiga doesn't use anything from the core PCMCIA code, instead
>>>> providing its own basic PCMCIA support code.
>>>>
>>>> I had initially duplicated some of the cis tuple parser code, but
>>>> decided to use what's already there instead.
>>>>
>>>> I can drop these selects, and add instructions to manually select
>>>> these options in the Kconfig help section. Seemed a little error prone
>>>> to me.
>>>
>>> Just make it the same as other drivers in this respect, please.
>>
>> "depends on PCMCIA" is what I've seen for other drivers. That is not
>> really appropriate for the APNE driver (8 bit cards work fine with
>> just the support code from arch/m68k/amiga/pcmcia.c).
>>
>> Please confirm that "depends on PCMCIA" is what you want me to use?
>
> Hi Michael,
>
> I don't want to see this driver using 'select', so that probably only
> leaves "depends on".
> But if you or Geert tell me that I am bonkers, so be it. :)

Are you OK with adding CONFIG_PCCARD=y and CONFIG_PCMCIA=y to 
amiga_defconfig to allow APNE to still be built when changed to depend 
on PCMCIA?

Cheers,

	Michael

>
> Thanks.