netdev - Re: [PATCH bpf 2/2] selftests/bpf: Add tests for allowed helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQLMT=HdG5K59NAZvaxjqzQmyF2b8fgVbCK8L7RM5NdrgQ@mail.gmail.com>
Date:   Wed, 10 Nov 2021 08:52:45 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Dmitrii Banshchikov <me@...que.spb.ru>
Cc:     Andrii Nakryiko <andrii.nakryiko@...il.com>,
        bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>, Martin Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        john fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Networking <netdev@...r.kernel.org>,
        Andrey Ignatov <rdna@...com>,
        John Stultz <john.stultz@...aro.org>, sboyd@...nel.org,
        Peter Ziljstra <peterz@...radead.org>,
        Mark Rutland <mark.rutland@....com>,
        Steven Rostedt <rosted@...dmis.org>
Subject: Re: [PATCH bpf 2/2] selftests/bpf: Add tests for allowed helpers

On Tue, Nov 9, 2021 at 11:32 PM Dmitrii Banshchikov <me@...que.spb.ru> wrote:
> >
> > Won't hurt, probably. But I wonder if it will be much easier to add
> > all those programs as C code and test from test_progs? Instead of all
> > this assembly.
> >
> > You can put all of them into a single file and have loop that disabled
> > all but one program at a time (using bpf_program__set_autoload()) and
> > loading it and validating that the load failed. WDYT?
>
> Will give it a try, thanks.

Please keep asm tests as well. They're useful too.