netdev - Re: [PATCH net] net: stmmac: fix system hang caused by eee_ctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 12 Nov 2021 15:43:31 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Joakim Zhang <qiangqing.zhang@....com>
Cc:     "peppe.cavallaro@...com" <peppe.cavallaro@...com>,
        "alexandre.torgue@...s.st.com" <alexandre.torgue@...s.st.com>,
        "joabreu@...opsys.com" <joabreu@...opsys.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        dl-linux-imx <linux-imx@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] net: stmmac: fix system hang caused by
 eee_ctrl_timer during suspend/resume

On Fri, Nov 12, 2021 at 01:21:57AM +0000, Joakim Zhang wrote:
> Hi Vladimir,
>
> > Hi Joakim,
> >
> > This patch looks strange to me. You are basically saying that the LPI timer for
> > MAC-level EEE is clocked from the clk_ptp_ref clock?! Are you sure this is
> > correct? I thought this clock is only used for the PTP timestamping counter.
> > Maybe the clock definitions in imx8mp.dtsi are not correct?
>
> No, MAC-level EEE is not clocked from the clk_ptp_ref clock, this clock is for PTP. To fix this issue,
> I can only move pm_runtime_force_suspend() into noirq suspend stage. As commit message said,
> "postpone clocks management from suspend stage to noirq suspend stage", that means I move all
> the clocks management into noirq suspend stage, including PTP clock, it's should be harmless for PTP
> function. Do you find any regression with this patch?

No, I didn't find any regression, I was just frustrated yesterday that a
bugfix patch I wanted to send to "stable" on the handling of clk_ptp_ref
is conflicting with your (apparently unnecessary) movement of this clock
to the noirq suspend stage. I'm better now.