netdev - Re: 32bit x86 build broken (was: Re: [GIT PULL] Networking for 5.16-rc1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9999b559abecea2eeb72b0b6973a31fcd39087c1.camel@linux.intel.com>
Date:   Fri, 12 Nov 2021 07:04:04 -0800
From:   Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>,
        NetFilter <netfilter-devel@...r.kernel.org>,
        linux-can@...r.kernel.org
Subject: Re: 32bit x86 build broken (was: Re: [GIT PULL] Networking for
 5.16-rc1)

On Fri, 2021-11-12 at 06:33 -0800, Jakub Kicinski wrote:
> On Thu, 11 Nov 2021 18:48:43 -0800 Linus Torvalds wrote:
> > On Thu, Nov 11, 2021 at 5:46 PM Jakub Kicinski <kuba@...nel.org>
> > wrote:
> > > Rafael, Srinivas, we're getting 32 bit build failures after pulling
> > > back
> > > from Linus today.
> > > 
> > > make[1]: *** [/home/nipa/net/Makefile:1850: drivers] Error 2
> > > make: *** [Makefile:219: __sub-make] Error 2
> > > ../drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c:
> > > In function ‘send_mbox_cmd’:
> > > ../drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c:7
> > > 9:37: error: implicit declaration of function ‘readq’; did you mean
> > > ‘readl’? [-Werror=implicit-function-declaration]
> > >    79 |                         *cmd_resp = readq((void __iomem *)
> > > (proc_priv->mmio_base + MBOX_OFFSET_DATA));
> > >       |                                     ^~~~~
> > >       |                                     readl  
> > 
> > Gaah.
> > 
> > The trivial fix is *probably* just a simple
> 
> To be sure - are you planning to wait for the fix to come via 
> the usual path?  We can hold applying new patches to net on the 
> off chance that you'd apply the fix directly and we can fast 
> forward again :) 
> 
> Not that 32bit x86 matters all that much in practice, it's just 
> for preventing new errors (64b divs, mostly) from sneaking in.
> 
> I'm guessing Rafeal may be AFK for the independence day weekend.
He was off, but not sure if he is back. I requested Daniel to send PULL
request for
https://lore.kernel.org/lkml/a22a1eeb-c7a0-74c1-46e2-0a7bada73520@infradead.org/T/