netdev - Re: [PATCH] tipc: check for null after calling kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 12 Nov 2021 20:08:28 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Tadeusz Struk <tadeusz.struk@...aro.org>
Cc:     jmaloy@...hat.com, Ying Xue <ying.xue@...driver.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        tipc-discussion@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Dmitry Vyukov <dvyukov@...gle.com>
Subject: Re: [PATCH] tipc: check for null after calling kmemdup

On Thu, 11 Nov 2021 12:59:15 -0800 Tadeusz Struk wrote:
> kmemdup can return a null pointer so need to check for it, otherwise
> the null key will be dereferenced later in tipc_crypto_key_xmit as
> can be seen in the trace [1].

> Reported-by: Dmitry Vyukov <dvyukov@...gle.com>
> Signed-off-by: Tadeusz Struk <tadeusz.struk@...aro.org>

Fixes: 1ef6f7c9390f ("tipc: add automatic session key exchange")