netdev - Re: [PATCH AUTOSEL 4.14 10/39] mwifiex: Run SET_BSS_MODE when changing from P2P to STATION vif-type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 14 Nov 2021 09:03:42 -0500
From:   Sasha Levin <sashal@...nel.org>
To:     Brian Norris <briannorris@...omium.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Jonas Dreßler <verdre@...d.nl>,
        Kalle Valo <kvalo@...eaurora.org>, amitkarwar@...il.com,
        ganapathi017@...il.com, sharvari.harisangam@....com,
        huxinming820@...il.com, davem@...emloft.net, kuba@...nel.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.14 10/39] mwifiex: Run SET_BSS_MODE when
 changing from P2P to STATION vif-type

On Tue, Nov 09, 2021 at 10:06:19AM -0800, Brian Norris wrote:
>On Mon, Nov 8, 2021 at 5:18 PM Sasha Levin <sashal@...nel.org> wrote:
>>
>> From: Jonas Dreßler <verdre@...d.nl>
>>
>> [ Upstream commit c2e9666cdffd347460a2b17988db4cfaf2a68fb9 ]
>...
>> This does not fix any particular bug and just "looked right", so there's
>> a small chance it might be a regression.
>
>I won't insist on rejecting this one, but especially given this
>sentence, this doesn't really pass the smell test for -stable
>candidates. It's stuff like this that pushes me a bit toward the camp
>of those who despise the ML-based selection methods here, even though
>it occasionally (or even often) may produce some good.

I have hundreds of examples of patches that claim they are just an
improvement but fix a serious bug :)

-- 
Thanks,
Sasha