netdev - Re: [PATCH net-next 00/20] tcp: optimizations for linux-5.17

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACSApvZ47Z9pKGxH_UU=yY+bQqdNt=jc2kpxP-VfZkCXLVSbCg@mail.gmail.com>
Date:   Mon, 15 Nov 2021 15:37:09 -0500
From:   Soheil Hassas Yeganeh <soheil@...gle.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Neal Cardwell <ncardwell@...gle.com>,
        Arjun Roy <arjunroy@...gle.com>
Subject: Re: [PATCH net-next 00/20] tcp: optimizations for linux-5.17

On Mon, Nov 15, 2021 at 2:02 PM Eric Dumazet <eric.dumazet@...il.com> wrote:
>
> From: Eric Dumazet <edumazet@...gle.com>
>
> Mostly small improvements in this series.
>
> The notable change is in "defer skb freeing after
> socket lock is released" in recvmsg() (and RX zerocopy)
>
> The idea is to try to let skb freeing to BH handler,
> whenever possible, or at least perform the freeing
> outside of the socket lock section, for much improved
> performance. This idea can probably be extended
> to other protocols.
>
>  Tests on a 100Gbit NIC
>  Max throughput for one TCP_STREAM flow, over 10 runs.
>
>  MTU : 1500  (1428 bytes of TCP payload per MSS)
>  Before: 55 Gbit
>  After:  66 Gbit
>
>  MTU : 4096+ (4096 bytes of TCP payload, plus TCP/IPv6 headers)
>  Before: 82 Gbit
>  After:  95 Gbit

Acked-by: Soheil Hassas Yeganeh <soheil@...gle.com>

Wow, this is really impressive. I reviewed all the patches and I can't
point out any issues other than the typo that Arjun has pointed out.
Thank you Eric!

> Eric Dumazet (20):
>   tcp: minor optimization in tcp_add_backlog()
>   tcp: remove dead code in __tcp_v6_send_check()
>   tcp: small optimization in tcp_v6_send_check()
>   net: use sk_is_tcp() in more places
>   net: remove sk_route_forced_caps
>   net: remove sk_route_nocaps
>   ipv6: shrink struct ipcm6_cookie
>   net: shrink struct sock by 8 bytes
>   net: forward_alloc_get depends on CONFIG_MPTCP
>   net: cache align tcp_memory_allocated, tcp_sockets_allocated
>   tcp: small optimization in tcp recvmsg()
>   tcp: add RETPOLINE mitigation to sk_backlog_rcv
>   tcp: annotate data-races on tp->segs_in and tp->data_segs_in
>   tcp: annotate races around tp->urg_data
>   tcp: tp->urg_data is unlikely to be set
>   tcp: avoid indirect calls to sock_rfree
>   tcp: defer skb freeing after socket lock is released
>   tcp: check local var (timeo) before socket fields in one test
>   tcp: do not call tcp_cleanup_rbuf() if we have a backlog
>   net: move early demux fields close to sk_refcnt
>
>  include/linux/skbuff.h     |  2 +
>  include/linux/skmsg.h      |  6 ---
>  include/net/ip6_checksum.h | 12 ++---
>  include/net/ipv6.h         |  4 +-
>  include/net/sock.h         | 51 +++++++++++++--------
>  include/net/tcp.h          | 18 +++++++-
>  net/core/skbuff.c          |  6 +--
>  net/core/sock.c            | 18 +++++---
>  net/ipv4/tcp.c             | 91 ++++++++++++++++++++++++++------------
>  net/ipv4/tcp_input.c       |  8 ++--
>  net/ipv4/tcp_ipv4.c        | 10 ++---
>  net/ipv4/tcp_output.c      |  2 +-
>  net/ipv4/udp.c             |  2 +-
>  net/ipv6/ip6_output.c      |  2 +-
>  net/ipv6/tcp_ipv6.c        | 10 ++---
>  net/mptcp/protocol.c       |  2 +-
>  16 files changed, 149 insertions(+), 95 deletions(-)
>
> --
> 2.34.0.rc1.387.gb447b232ab-goog
>