netdev - Re: [PATCH v2] can: etas_es58x: fix error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a98b159-f9bf-c0dd-f244-aec6c9a7dcaa@gmail.com>
Date:   Mon, 15 Nov 2021 11:15:07 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Johan Hovold <johan@...nel.org>
Cc:     mailhol.vincent@...adoo.fr, wg@...ndegger.com, mkl@...gutronix.de,
        davem@...emloft.net, kuba@...nel.org, linux-can@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] can: etas_es58x: fix error handling

On 11/15/21 11:11, Johan Hovold wrote:
> Just a drive-by comment:
> 
> Are you sure about this move of the netdev[channel_idx] initialisation?
> What happens if the registered can device is opened before you
> initialise the pointer? NULL-deref in es58x_send_msg()?
> 
> You generally want the driver data fully initialised before you register
> the device so this looks broken.
> 
> And either way it is arguably an unrelated change that should go in a
> separate patch explaining why it is needed and safe.
> 


It was suggested by Vincent who is the maintainer of this driver [1].



[1] 
https://lore.kernel.org/linux-can/CAMZ6Rq+orfUuUCCgeWyGc7P0vp3t-yjf_g9H=Jhk43f1zXGfDQ@mail.gmail.com/



With regards,
Pavel Skripkin