netdev - [ethtool PATCH] ethtool: Set mask correctly for dumping advertised FEC modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Nov 2021 14:52:54 -0800
From:   Alexander Duyck <alexander.duyck@...il.com>
To:     mkubecek@...e.cz, netdev@...r.kernel.org
Subject: [ethtool PATCH] ethtool: Set mask correctly for dumping advertised
 FEC modes

From: Alexander Duyck <alexanderduyck@...com>

Set the "mask" value to false when dumping the advertised FEC modes.
The advertised values are stored in the value field, while the supported
values are what is stored in the mask.

Without this change the supported value is displayed for both the supported
and advertised modes resulting in the advertised value being ignored.

Signed-off-by: Alexander Duyck <alexanderduyck@...com>
---
 netlink/settings.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/netlink/settings.c b/netlink/settings.c
index c4f5d61923aa..ff1e783d099c 100644
--- a/netlink/settings.c
+++ b/netlink/settings.c
@@ -402,7 +402,7 @@ static int dump_our_modes(struct nl_context *nlctx, const struct nlattr *attr)
 		return ret;
 	printf("\tAdvertised auto-negotiation: %s\n", autoneg ? "Yes" : "No");
 
-	ret = dump_link_modes(nlctx, attr, true, LM_CLASS_FEC,
+	ret = dump_link_modes(nlctx, attr, false, LM_CLASS_FEC,
 			      "Advertised FEC modes: ", " ", "\n",
 			      "Not reported");
 	return ret;