netdev - Re: [PATCH] tipc: check for null after calling kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211116113232.45eceecf@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 16 Nov 2021 11:32:32 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Tadeusz Struk <tadeusz.struk@...aro.org>
Cc:     Jon Maloy <jmaloy@...hat.com>, Ying Xue <ying.xue@...driver.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        tipc-discussion@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Dmitry Vyukov <dvyukov@...gle.com>
Subject: Re: [PATCH] tipc: check for null after calling kmemdup

On Fri, 12 Nov 2021 21:42:11 -0800 Tadeusz Struk wrote:
> On 11/12/21 20:13, Jakub Kicinski wrote:
>  [...]  
> >> Acked-by: Jon Maloy<jmaloy@...hat.com>  
> > Hm, shouldn't we free all the tfm entries here?  
> 
> Right, I think we just need to call tipc_aead_free(&tmp->rcu);
> here and return an error.

Would be good to get an ack From Jon or Ying on that one.