| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 17 Nov 2021 06:20:04 +0800
From: kernel test robot <lkp@...el.com>
To: Ansuel Smith <ansuelsmth@...il.com>, Andrew Lunn <andrew@...n.ch>,
Vivien Didelot <vivien.didelot@...il.com>,
Florian Fainelli <f.fainelli@...il.com>,
Vladimir Oltean <olteanv@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Jonathan Corbet <corbet@....net>, Pavel Machek <pavel@....cz>
Cc: kbuild-all@...ts.01.org, netdev@...r.kernel.org
Subject: Re: [PATCH v5 6/8] leds: trigger: add hardware-phy-activity trigger
Hi Ansuel,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net/master]
[also build test ERROR on linus/master v5.16-rc1 next-20211116]
[cannot apply to pavel-leds/for-next robh/for-next net-next/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Ansuel-Smith/Adds-support-for-PHY-LEDs-with-offload-triggers/20211112-233807
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 5833291ab6de9c3e2374336b51c814e515e8f3a5
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/e7d3e80887a86c5ce15c7fb3cd93807cd19dfd53
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Ansuel-Smith/Adds-support-for-PHY-LEDs-with-offload-triggers/20211112-233807
git checkout e7d3e80887a86c5ce15c7fb3cd93807cd19dfd53
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/leds/trigger/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
drivers/leds/trigger/ledtrig-hardware-phy-activity.c: In function 'blink_mode_common_show':
>> drivers/leds/trigger/ledtrig-hardware-phy-activity.c:17:42: error: dereferencing pointer to incomplete type 'struct hardware_phy_activity_data'
17 | val = test_bit(blink_mode, &trigger_data->mode);
| ^~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c: In function 'blink_mode_common_store':
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:35:36: error: dereferencing pointer to incomplete type 'struct hardware_phy_activity_data'
35 | set_bit(blink_mode, &trigger_data->mode);
| ^~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c: In function 'blink_tx_show':
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:59:32: error: 'TRIGGER_PHY_ACTIVITY_BLINK_TX' undeclared (first use in this function)
59 | DEFINE_HW_BLINK_MODE(blink_tx, TRIGGER_PHY_ACTIVITY_BLINK_TX);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:48:33: note: in definition of macro 'DEFINE_HW_BLINK_MODE'
48 | return blink_mode_common_show(blink_bit, dev, attr, buf); \
| ^~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:59:32: note: each undeclared identifier is reported only once for each function it appears in
59 | DEFINE_HW_BLINK_MODE(blink_tx, TRIGGER_PHY_ACTIVITY_BLINK_TX);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:48:33: note: in definition of macro 'DEFINE_HW_BLINK_MODE'
48 | return blink_mode_common_show(blink_bit, dev, attr, buf); \
| ^~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c: In function 'blink_tx_store':
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:59:32: error: 'TRIGGER_PHY_ACTIVITY_BLINK_TX' undeclared (first use in this function)
59 | DEFINE_HW_BLINK_MODE(blink_tx, TRIGGER_PHY_ACTIVITY_BLINK_TX);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:54:34: note: in definition of macro 'DEFINE_HW_BLINK_MODE'
54 | return blink_mode_common_store(blink_bit, dev, attr, buf, size); \
| ^~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c: In function 'blink_rx_show':
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:60:32: error: 'TRIGGER_PHY_ACTIVITY_BLINK_RX' undeclared (first use in this function)
60 | DEFINE_HW_BLINK_MODE(blink_rx, TRIGGER_PHY_ACTIVITY_BLINK_RX);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:48:33: note: in definition of macro 'DEFINE_HW_BLINK_MODE'
48 | return blink_mode_common_show(blink_bit, dev, attr, buf); \
| ^~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c: In function 'blink_rx_store':
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:60:32: error: 'TRIGGER_PHY_ACTIVITY_BLINK_RX' undeclared (first use in this function)
60 | DEFINE_HW_BLINK_MODE(blink_rx, TRIGGER_PHY_ACTIVITY_BLINK_RX);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:54:34: note: in definition of macro 'DEFINE_HW_BLINK_MODE'
54 | return blink_mode_common_store(blink_bit, dev, attr, buf, size); \
| ^~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c: In function 'link_10M_show':
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:61:32: error: 'TRIGGER_PHY_ACTIVITY_LINK_10M' undeclared (first use in this function)
61 | DEFINE_HW_BLINK_MODE(link_10M, TRIGGER_PHY_ACTIVITY_LINK_10M);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:48:33: note: in definition of macro 'DEFINE_HW_BLINK_MODE'
48 | return blink_mode_common_show(blink_bit, dev, attr, buf); \
| ^~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c: In function 'link_10M_store':
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:61:32: error: 'TRIGGER_PHY_ACTIVITY_LINK_10M' undeclared (first use in this function)
61 | DEFINE_HW_BLINK_MODE(link_10M, TRIGGER_PHY_ACTIVITY_LINK_10M);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:54:34: note: in definition of macro 'DEFINE_HW_BLINK_MODE'
54 | return blink_mode_common_store(blink_bit, dev, attr, buf, size); \
| ^~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c: In function 'link_100M_show':
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:62:33: error: 'TRIGGER_PHY_ACTIVITY_LINK_100M' undeclared (first use in this function)
62 | DEFINE_HW_BLINK_MODE(link_100M, TRIGGER_PHY_ACTIVITY_LINK_100M);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:48:33: note: in definition of macro 'DEFINE_HW_BLINK_MODE'
48 | return blink_mode_common_show(blink_bit, dev, attr, buf); \
| ^~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c: In function 'link_100M_store':
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:62:33: error: 'TRIGGER_PHY_ACTIVITY_LINK_100M' undeclared (first use in this function)
62 | DEFINE_HW_BLINK_MODE(link_100M, TRIGGER_PHY_ACTIVITY_LINK_100M);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:54:34: note: in definition of macro 'DEFINE_HW_BLINK_MODE'
54 | return blink_mode_common_store(blink_bit, dev, attr, buf, size); \
| ^~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c: In function 'link_1000M_show':
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:63:34: error: 'TRIGGER_PHY_ACTIVITY_LINK_1000M' undeclared (first use in this function)
63 | DEFINE_HW_BLINK_MODE(link_1000M, TRIGGER_PHY_ACTIVITY_LINK_1000M);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:48:33: note: in definition of macro 'DEFINE_HW_BLINK_MODE'
48 | return blink_mode_common_show(blink_bit, dev, attr, buf); \
| ^~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c: In function 'link_1000M_store':
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:63:34: error: 'TRIGGER_PHY_ACTIVITY_LINK_1000M' undeclared (first use in this function)
63 | DEFINE_HW_BLINK_MODE(link_1000M, TRIGGER_PHY_ACTIVITY_LINK_1000M);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:54:34: note: in definition of macro 'DEFINE_HW_BLINK_MODE'
54 | return blink_mode_common_store(blink_bit, dev, attr, buf, size); \
| ^~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c: In function 'half_duplex_show':
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:64:35: error: 'TRIGGER_PHY_ACTIVITY_HALF_DUPLEX' undeclared (first use in this function)
64 | DEFINE_HW_BLINK_MODE(half_duplex, TRIGGER_PHY_ACTIVITY_HALF_DUPLEX);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:48:33: note: in definition of macro 'DEFINE_HW_BLINK_MODE'
48 | return blink_mode_common_show(blink_bit, dev, attr, buf); \
| ^~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c: In function 'half_duplex_store':
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:64:35: error: 'TRIGGER_PHY_ACTIVITY_HALF_DUPLEX' undeclared (first use in this function)
64 | DEFINE_HW_BLINK_MODE(half_duplex, TRIGGER_PHY_ACTIVITY_HALF_DUPLEX);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:54:34: note: in definition of macro 'DEFINE_HW_BLINK_MODE'
54 | return blink_mode_common_store(blink_bit, dev, attr, buf, size); \
| ^~~~~~~~~
drivers/leds/trigger/ledtrig-hardware-phy-activity.c: In function 'full_duplex_show':
drivers/leds/trigger/ledtrig-hardware-phy-activity.c:65:35: error: 'TRIGGER_PHY_ACTIVITY_FULL_DUPLEX' undeclared (first use in this function)
65 | DEFINE_HW_BLINK_MODE(full_duplex, TRIGGER_PHY_ACTIVITY_FULL_DUPLEX);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +17 drivers/leds/trigger/ledtrig-hardware-phy-activity.c
9
10 static ssize_t blink_mode_common_show(int blink_mode, struct device *dev,
11 struct device_attribute *attr, char *buf)
12 {
13 struct led_classdev *led_cdev = led_trigger_get_led(dev);
14 struct hardware_phy_activity_data *trigger_data = led_cdev->trigger_data;
15 int val;
16
> 17 val = test_bit(blink_mode, &trigger_data->mode);
18 return sprintf(buf, "%d\n", val ? 1 : 0);
19 }
20
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (67575 bytes)
Powered by blists - more mailing lists