netdev - Re: [PATCH net-next v5 3/3] tsnep: Add TSN endpoint Ethernet MAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZRBkMsOhKB7nFW1@lunn.ch>
Date:   Wed, 17 Nov 2021 00:41:04 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Gerhard Engleder <gerhard@...leder-embedded.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v5 3/3] tsnep: Add TSN endpoint Ethernet MAC
 driver

> > > diff --git a/drivers/net/ethernet/engleder/tsnep_test.c b/drivers/net/ethernet/engleder/tsnep_test.c
> >
> > You have quite a lot of code in this file. Could it either be
> >
> > 1) A loadable module which extends the base driver?
> > 2) A build time configuration option?
> >
> > What percentage of the overall driver binary does this test code take
> > up?
> 
> Driver is 484kB with test code and 396kB without. So test code is roughly
> 20% currently. In my opinion a configuration option makes more sense,

Yes, that is good, please add one.

     Andrew