netdev - Re: [PATCH net] net: virtio_net_hdr_to_skb: count transport header in UFO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211115171319.7d2e9f40@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 15 Nov 2021 17:13:19 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jonathan Davies <jonathan.davies@...anix.com>
Cc:     Willem de Bruijn <willemb@...gle.com>, netdev@...r.kernel.org,
        Florian Schmidt <flosch@...anix.com>,
        Thilak Raj Surendra Babu <thilakraj.sb@...anix.com>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        "David S. Miller" <davem@...emloft.net>,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: virtio_net_hdr_to_skb: count transport header
 in UFO

On Mon, 15 Nov 2021 15:16:17 +0000 Jonathan Davies wrote:
> +		if (gso_type & SKB_GSO_UDP && skb->len - p_off + thlen > gso_size ||

Compilers don't like mixing && and || without bracketing, and will warn
here, at least with W=1. Please add explicit brackets.