| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <2fdf21c4-57f9-0a51-a598-c5494aeae6a6@huawei.com>
Date: Tue, 16 Nov 2021 10:29:05 +0800
From: "huangguangbin (A)" <huangguangbin2@...wei.com>
To: <davem@...emloft.net>, <kuba@...nel.org>, <mkubecek@...e.cz>,
<andrew@...n.ch>, <amitc@...lanox.com>, <idosch@...sch.org>,
<danieller@...dia.com>, <jesse.brandeburg@...el.com>,
<anthony.l.nguyen@...el.com>, <jdike@...toit.com>,
<richard@....at>, <anton.ivanov@...bridgegreys.com>,
<netanel@...zon.com>, <akiyano@...zon.com>, <gtzalik@...zon.com>,
<saeedb@...zon.com>, <chris.snook@...il.com>,
<ulli.kroll@...glemail.com>, <linus.walleij@...aro.org>,
<jeroendb@...gle.com>, <csully@...gle.com>,
<awogbemila@...gle.com>, <jdmason@...zu.us>,
<rain.1986.08.12@...il.com>, <zyjzyj2000@...il.com>,
<kys@...rosoft.com>, <haiyangz@...rosoft.com>, <mst@...hat.com>,
<jasowang@...hat.com>, <doshir@...are.com>,
<pv-drivers@...are.com>, <jwi@...ux.ibm.com>,
<kgraul@...ux.ibm.com>, <hca@...ux.ibm.com>, <gor@...ux.ibm.com>,
<johannes@...solutions.net>
CC: <netdev@...r.kernel.org>, <lipeng321@...wei.com>,
<chenhao288@...ilicon.com>, <linux-s390@...r.kernel.org>
Subject: Re: [PATCH V6 net-next 0/6] ethtool: add support to set/get tx
copybreak buf size and rx buf len
Gentle ping.
Are there any suggestions for this series?
On 2021/11/2 21:46, Guangbin Huang wrote:
> From: Hao Chen <chenhao288@...ilicon.com>
>
> This series add support to set/get tx copybreak buf size and rx buf len via
> ethtool and hns3 driver implements them.
>
> Tx copybreak buf size is used for tx copybreak feature which for small size
> packet or frag. Use ethtool --get-tunable command to get it, and ethtool
> --set-tunable command to set it, examples are as follow:
>
> 1. set tx spare buf size to 102400:
> $ ethtool --set-tunable eth1 tx-buf-size 102400
>
> 2. get tx spare buf size:
> $ ethtool --get-tunable eth1 tx-buf-size
> tx-buf-size: 102400
>
> Rx buf len is buffer length of each rx BD. Use ethtool -g command to get
> it, and ethtool -G command to set it, examples are as follow:
>
> 1. set rx buf len to 4096
> $ ethtool -G eth1 rx-buf-len 4096
>
> 2. get rx buf len
> $ ethtool -g eth1
> ...
> RX Buf Len: 4096
>
>
> Change log:
> V5 -> V6
> 1.Fix compile error for divers/s390.
>
> V4 -> V5
> 1.Change struct ethtool_ringparam_ext to kernel_ethtool_ringparam.
> 2.change "__u32 rx_buf_len" to "u32 rx_buf_len".
>
> V3 -> V4
> 1.Fix a few allmodconfig compile warning.
> 2.Add more '=' synbol to ethtool-netlink.rst to refine format.
> 3.Move definement of struct ethtool_ringparam_ext to include/linux/ethtool.h.
> 4.Move related modify of rings_fill_reply() from patch 4/6 to patch 3/6.
>
> V2 -> V3
> 1.Remove documentation for tx copybreak buf size, there is description for
> it in userspace ethtool.
> 2.Move extending parameters for get/set_ringparam function from patch3/6
> to patch 4/6.
>
> V1 -> V2
> 1.Add documentation for rx buf len and tx copybreak buf size.
> 2.Extend structure ringparam_ext for extenal ring params.
> 3.Change type of ETHTOOL_A_RINGS_RX_BUF_LEN from NLA_U32 to
> NLA_POLICY_MIN(NLA_U32, 1).
> 4.Add supported_ring_params in ethtool_ops to indicate if support external
> params.
>
>
> Hao Chen (6):
> ethtool: add support to set/get tx copybreak buf size via ethtool
> net: hns3: add support to set/get tx copybreak buf size via ethtool
> for hns3 driver
> ethtool: add support to set/get rx buf len via ethtool
> ethtool: extend ringparam setting/getting API with rx_buf_len
> net: hns3: add support to set/get rx buf len via ethtool for hns3
> driver
> net: hns3: remove the way to set tx spare buf via module parameter
>
> Documentation/networking/ethtool-netlink.rst | 10 +-
> arch/um/drivers/vector_kern.c | 4 +-
> drivers/net/can/c_can/c_can_ethtool.c | 4 +-
> drivers/net/ethernet/3com/typhoon.c | 4 +-
> drivers/net/ethernet/amazon/ena/ena_ethtool.c | 8 +-
> drivers/net/ethernet/amd/pcnet32.c | 8 +-
> drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c | 11 +-
> .../ethernet/aquantia/atlantic/aq_ethtool.c | 8 +-
> drivers/net/ethernet/atheros/atlx/atl1.c | 8 +-
> drivers/net/ethernet/broadcom/b44.c | 8 +-
> drivers/net/ethernet/broadcom/bcm63xx_enet.c | 25 ++--
> drivers/net/ethernet/broadcom/bnx2.c | 8 +-
> .../ethernet/broadcom/bnx2x/bnx2x_ethtool.c | 8 +-
> .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 8 +-
> drivers/net/ethernet/broadcom/tg3.c | 10 +-
> .../net/ethernet/brocade/bna/bnad_ethtool.c | 8 +-
> drivers/net/ethernet/cadence/macb_main.c | 8 +-
> .../ethernet/cavium/liquidio/lio_ethtool.c | 11 +-
> .../ethernet/cavium/thunder/nicvf_ethtool.c | 8 +-
> drivers/net/ethernet/chelsio/cxgb/cxgb2.c | 8 +-
> .../net/ethernet/chelsio/cxgb3/cxgb3_main.c | 8 +-
> .../ethernet/chelsio/cxgb4/cxgb4_ethtool.c | 8 +-
> .../ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 8 +-
> .../net/ethernet/cisco/enic/enic_ethtool.c | 8 +-
> drivers/net/ethernet/cortina/gemini.c | 8 +-
> .../net/ethernet/emulex/benet/be_ethtool.c | 4 +-
> drivers/net/ethernet/ethoc.c | 8 +-
> drivers/net/ethernet/faraday/ftgmac100.c | 14 ++-
> .../ethernet/freescale/enetc/enetc_ethtool.c | 4 +-
> .../net/ethernet/freescale/gianfar_ethtool.c | 8 +-
> .../net/ethernet/freescale/ucc_geth_ethtool.c | 8 +-
> drivers/net/ethernet/google/gve/gve_ethtool.c | 4 +-
> .../net/ethernet/hisilicon/hns/hns_ethtool.c | 6 +-
> .../net/ethernet/hisilicon/hns3/hns3_enet.c | 11 +-
> .../net/ethernet/hisilicon/hns3/hns3_enet.h | 2 +
> .../ethernet/hisilicon/hns3/hns3_ethtool.c | 116 ++++++++++++++++--
> .../net/ethernet/huawei/hinic/hinic_ethtool.c | 8 +-
> drivers/net/ethernet/ibm/emac/core.c | 7 +-
> drivers/net/ethernet/ibm/ibmvnic.c | 8 +-
> drivers/net/ethernet/intel/e100.c | 8 +-
> .../net/ethernet/intel/e1000/e1000_ethtool.c | 8 +-
> drivers/net/ethernet/intel/e1000e/ethtool.c | 8 +-
> .../net/ethernet/intel/fm10k/fm10k_ethtool.c | 8 +-
> .../net/ethernet/intel/i40e/i40e_ethtool.c | 8 +-
> .../net/ethernet/intel/iavf/iavf_ethtool.c | 12 +-
> drivers/net/ethernet/intel/ice/ice_ethtool.c | 8 +-
> drivers/net/ethernet/intel/igb/igb_ethtool.c | 8 +-
> drivers/net/ethernet/intel/igbvf/ethtool.c | 8 +-
> drivers/net/ethernet/intel/igc/igc_ethtool.c | 14 ++-
> .../net/ethernet/intel/ixgb/ixgb_ethtool.c | 8 +-
> .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 8 +-
> drivers/net/ethernet/intel/ixgbevf/ethtool.c | 8 +-
> drivers/net/ethernet/marvell/mv643xx_eth.c | 8 +-
> drivers/net/ethernet/marvell/mvneta.c | 14 ++-
> .../net/ethernet/marvell/mvpp2/mvpp2_main.c | 14 ++-
> .../marvell/octeontx2/nic/otx2_ethtool.c | 8 +-
> drivers/net/ethernet/marvell/skge.c | 8 +-
> drivers/net/ethernet/marvell/sky2.c | 8 +-
> .../net/ethernet/mellanox/mlx4/en_ethtool.c | 8 +-
> .../ethernet/mellanox/mlx5/core/en_ethtool.c | 8 +-
> .../net/ethernet/mellanox/mlx5/core/en_rep.c | 14 ++-
> .../mellanox/mlx5/core/ipoib/ethtool.c | 8 +-
> .../mellanox/mlxbf_gige/mlxbf_gige_ethtool.c | 7 +-
> drivers/net/ethernet/micrel/ksz884x.c | 6 +-
> .../net/ethernet/myricom/myri10ge/myri10ge.c | 4 +-
> drivers/net/ethernet/neterion/s2io.c | 7 +-
> .../ethernet/netronome/nfp/nfp_net_ethtool.c | 8 +-
> drivers/net/ethernet/nvidia/forcedeth.c | 10 +-
> .../oki-semi/pch_gbe/pch_gbe_ethtool.c | 12 +-
> .../net/ethernet/pasemi/pasemi_mac_ethtool.c | 4 +-
> .../ethernet/pensando/ionic/ionic_ethtool.c | 8 +-
> .../qlogic/netxen/netxen_nic_ethtool.c | 8 +-
> .../net/ethernet/qlogic/qede/qede_ethtool.c | 8 +-
> .../ethernet/qlogic/qlcnic/qlcnic_ethtool.c | 8 +-
> .../net/ethernet/qualcomm/emac/emac-ethtool.c | 8 +-
> drivers/net/ethernet/qualcomm/qca_debug.c | 8 +-
> drivers/net/ethernet/realtek/8139cp.c | 4 +-
> drivers/net/ethernet/realtek/r8169_main.c | 4 +-
> drivers/net/ethernet/renesas/ravb_main.c | 8 +-
> drivers/net/ethernet/renesas/sh_eth.c | 8 +-
> drivers/net/ethernet/sfc/ef100_ethtool.c | 7 +-
> drivers/net/ethernet/sfc/ethtool.c | 14 ++-
> drivers/net/ethernet/sfc/falcon/ethtool.c | 14 ++-
> .../ethernet/stmicro/stmmac/stmmac_ethtool.c | 8 +-
> drivers/net/ethernet/tehuti/tehuti.c | 12 +-
> drivers/net/ethernet/ti/am65-cpsw-ethtool.c | 7 +-
> drivers/net/ethernet/ti/cpmac.c | 8 +-
> drivers/net/ethernet/ti/cpsw_ethtool.c | 8 +-
> drivers/net/ethernet/ti/cpsw_priv.h | 8 +-
> .../net/ethernet/toshiba/spider_net_ethtool.c | 4 +-
> drivers/net/ethernet/xilinx/ll_temac_main.c | 14 ++-
> .../net/ethernet/xilinx/xilinx_axienet_main.c | 14 ++-
> drivers/net/hyperv/netvsc_drv.c | 8 +-
> drivers/net/netdevsim/ethtool.c | 8 +-
> drivers/net/usb/r8152.c | 8 +-
> drivers/net/virtio_net.c | 4 +-
> drivers/net/vmxnet3/vmxnet3_ethtool.c | 10 +-
> drivers/s390/net/qeth_ethtool.c | 4 +-
> include/linux/ethtool.h | 26 +++-
> include/uapi/linux/ethtool.h | 1 +
> include/uapi/linux/ethtool_netlink.h | 1 +
> net/ethtool/common.c | 1 +
> net/ethtool/ioctl.c | 11 +-
> net/ethtool/netlink.h | 2 +-
> net/ethtool/rings.c | 32 ++++-
> net/mac80211/ethtool.c | 8 +-
> 106 files changed, 772 insertions(+), 235 deletions(-)
>
Powered by blists - more mailing lists