netdev - Re: Set __LINK_STATE_NOCARRIER in register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211116185145.4ee927d2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 16 Nov 2021 18:51:45 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: Set __LINK_STATE_NOCARRIER in register_netdevice() ?

On Tue, 16 Nov 2021 21:47:21 +0100 Heiner Kallweit wrote:
> Quite some network drivers call netif_carrier_off() in their probe() function.
> So I'm wondering whether we can/should add a
> set_bit(__LINK_STATE_NOCARRIER, &dev->state)
> to register_netdevice() and remove all these netif_carrier_off() calls.
> 
> Question is whether there's any scenario where a driver would depend on bit
> __LINK_STATE_NOCARRIER being cleared after registering the netdevice
> or where we want to preserve the state of this bit.

I thought that conversely many sw devices never touch carrier, hence
letting it remain up with operstate unknown. We'd be changing that,
dunno if it matters.