[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20211117032924.1740327-1-eric.dumazet@gmail.com>
Date: Tue, 16 Nov 2021 19:29:20 -0800
From: Eric Dumazet <eric.dumazet@...il.com>
To: "David S . Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>
Cc: netdev <netdev@...r.kernel.org>,
Eric Dumazet <edumazet@...gle.com>,
Eric Dumazet <eric.dumazet@...il.com>
Subject: [PATCH net-next 0/4] net: make dev_watchdog() less intrusive
From: Eric Dumazet <edumazet@...gle.com>
dev_watchdog() is used on many NIC to periodically monitor TX queues
to detect hangs.
Problem is : It stops all queues, then check them, then 'unfreeze' them.
Not only this stops feeding the NIC, it also migrates all qdiscs
to be serviced on the cpu calling netif_tx_unlock(), causing
a potential latency artifact.
With many TX queues, this is becoming more visible.
Eric Dumazet (4):
net: use an atomic_long_t for queue->trans_timeout
net: annotate accesses to queue->trans_start
net: do not inline netif_tx_lock()/netif_tx_unlock()
net: no longer stop all TX queues in dev_watchdog()
.../net/ethernet/apm/xgene/xgene_enet_main.c | 2 +-
drivers/net/ethernet/atheros/ag71xx.c | 2 +-
.../net/ethernet/freescale/dpaa/dpaa_eth.c | 4 +-
.../net/ethernet/hisilicon/hns3/hns3_enet.c | 2 +-
drivers/net/ethernet/ibm/ibmvnic.c | 2 +-
drivers/net/ethernet/intel/igb/igb_main.c | 4 +-
.../mellanox/mlx5/core/en/reporter_tx.c | 2 +-
.../net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +-
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 2 +-
drivers/net/virtio_net.c | 2 +-
drivers/net/wireless/marvell/mwifiex/init.c | 2 +-
drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
include/linux/netdevice.h | 57 +++++----------
net/core/net-sysfs.c | 6 +-
net/sched/sch_generic.c | 69 ++++++++++++++++---
15 files changed, 94 insertions(+), 70 deletions(-)
--
2.34.0.rc1.387.gb447b232ab-goog
Powered by blists - more mailing lists