netdev - Re: [PATCH net-next] Bonding: add missed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YZStQmciqidnkL3/@Laptop-X1>
Date:   Wed, 17 Nov 2021 15:20:34 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, Jay Vosburgh <j.vosburgh@...il.com>,
        Veaceslav Falico <vfalico@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        Jarod Wilson <jarod@...hat.com>, Jiri Pirko <jiri@...nulli.us>,
        "David S . Miller" <davem@...emloft.net>,
        Denis Kirjanov <dkirjanov@...e.de>,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH net-next] Bonding: add missed_max option

On Tue, Nov 16, 2021 at 06:41:55PM -0800, Jakub Kicinski wrote:
> On Wed, 17 Nov 2021 09:01:15 +0800 Hangbin Liu wrote:
> > > >  
> > > >  static const struct nla_policy bond_slave_policy[IFLA_BOND_SLAVE_MAX + 1] = {
> > > > @@ -453,6 +454,15 @@ static int bond_changelink(struct net_device *bond_dev, struct nlattr *tb[],
> > > >  			return err;
> > > >  	}
> > > >  
> > > > +	if (data[IFLA_BOND_MISSED_MAX]) {
> > > > +		int missed_max = nla_get_u8(data[IFLA_BOND_MISSED_MAX]);  
> > > 
> > > If you read and write a u8?  
> > 
> > Ah, that's a typo. I planed to use nla_get_u32(). But looks NLA_U8 also should
> > be enough. WDYT?
> 
> Either way is fine. To be sure we don't need to enforce any lower limit
> here? 0 is a valid setting?

Re-considered and I agree that the value should not be set to 0.

Thanks
Hangbin