netdev - Re: [PATCH bpf-next 2/7] set_memory: introduce set_memory_[ro|x]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9DB9C25B-735F-4310-B937-56124DB59CDF@fb.com>
Date:   Thu, 18 Nov 2021 17:16:24 +0000
From:   Song Liu <songliubraving@...com>
To:     Peter Zijlstra <peterz@...radead.org>
CC:     Johannes Weiner <hannes@...xchg.org>,
        the arch/x86 maintainers <x86@...nel.org>,
        bpf <bpf@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "ast@...nel.org" <ast@...nel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "andrii@...nel.org" <andrii@...nel.org>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH bpf-next 2/7] set_memory: introduce
 set_memory_[ro|x]_noalias



> On Nov 17, 2021, at 11:54 PM, Peter Zijlstra <peterz@...radead.org> wrote:
> 
> On Wed, Nov 17, 2021 at 11:57:12PM +0000, Song Liu wrote:
> 
>> I would agree that __text_poke() is a safer option. But in this case, we 
>> will need the temporary hole to be 2MB in size. Also, we will probably 
>> hold the temporary mapping for longer time (the whole JITing process). 
>> Does this sound reasonable?
> 
> No :-)
> 
> Jit to a buffer, then copy the buffer into the 2M page using 4k aliases.
> IIRC each program is still smaller than a single page, right? So at no
> point do you need more than 2 pages mapped anyway.

JITing to a separate buffer adds complexity to the JIT process, as we 
need to redo some offsets before the copy to match the final location of 
the program. I don't have much experience with the JIT engine, so I am
not very sure how much work it gonna be. 

The BPF program could have up to 1000000 (BPF_COMPLEXITY_LIMIT_INSNS)
instructions (BPF instructions). So it could easily go beyond a few 
pages. Mapping the 2MB page all together should make the logic simpler. 

Thanks,
Song