netdev - Re: [PATCH net v11 3/3] net/8390: apne.c - add 100 Mbit support to apne.c driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Nov 2021 11:18:44 -0800
From:   Joe Perches <joe@...ches.com>
To:     Michael Schmitz <schmitzmic@...il.com>, linux-m68k@...r.kernel.org,
        geert@...ux-m68k.org
Cc:     alex@...ik.de, netdev@...r.kernel.org
Subject: Re: [PATCH net v11 3/3] net/8390: apne.c - add 100 Mbit support to
 apne.c driver

On Mon, 2021-11-15 at 12:40 +1300, Michael Schmitz wrote:
> Add module parameter, IO mode autoprobe and PCMCIA reset code
> required to support 100 Mbit PCMCIA ethernet cards on Amiga.
[]
> diff --git a/drivers/net/ethernet/8390/apne.c b/drivers/net/ethernet/8390/apne.c
[]
> @@ -119,6 +119,48 @@ static u32 apne_msg_enable;
[]
> +	cftuple_len = pcmcia_copy_tuple(CISTPL_CFTABLE_ENTRY, cftuple, 256);
> +	if (cftuple_len < 3)
> +		return 0;
> +#ifdef DEBUG
> +	else
> +		print_hex_dump(KERN_WARNING, "cftable: ", DUMP_PREFIX_NONE, 8,
> +			       sizeof(char), cftuple, cftuple_len, false);
> +#endif

Why KERN_WARNING and why not use print_hex_dump_debug without the #ifdef

[]
> +#ifdef DEBUG
> +	pr_info("IO flags: %x\n", cftable_entry.io.flags);

pr_debug ?