netdev - Re: [PATCH net-next] sky2: use PCI VPD API in eeprom ethtool ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211118123813.2f11dcac@hermes.local>
Date:   Thu, 18 Nov 2021 12:38:13 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Mirko Lindner <mlindner@...vell.com>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] sky2: use PCI VPD API in eeprom ethtool ops

On Thu, 18 Nov 2021 21:04:23 +0100
Heiner Kallweit <hkallweit1@...il.com> wrote:

> Recently pci_read/write_vpd_any() have been added to the PCI VPD API.
> These functions allow to access VPD address space outside the
> auto-detected VPD, and they can be used to significantly simplify the
> eeprom ethtool ops.
> 
> Tested with a 88E8070 card with 1KB EEPROM.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---

Looks like a good idea. I don't have sky2 hardware in a system anymore.

Reviewed-by: Stephen Hemminger <stephen@...workplumber.org>