netdev - Re: [PATCH v2] nfc: st21nfca: Fix potential buffer overflows in EVT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <879d53ad-1819-d556-3403-daf26b08ba41@canonical.com>
Date:   Thu, 18 Nov 2021 08:40:16 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Jordy Zomer <jordy@...ing.systems>, linux-kernel@...r.kernel.org
Cc:     Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH v2] nfc: st21nfca: Fix potential buffer overflows in
 EVT_TRANSACTION

On 18/11/2021 08:04, Jordy Zomer wrote:
> It appears that there are some buffer overflows in EVT_TRANSACTION.
> This happens because the length parameters that are passed to memcpy
> come directly from skb->data and are not guarded in any way.
> 
> It would be nice if someone can review and test this patch because
> I don't own the hardware :)
> 
> EDIT: Changed the comment styles and removed double newlines
> 

Same comments apply. :)


Best regards,
Krzysztof