lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 19 Nov 2021 01:59:58 +0200 From: Vladimir Oltean <olteanv@...il.com> To: Ansuel Smith <ansuelsmth@...il.com> Cc: Andrew Lunn <andrew@...n.ch>, Vivien Didelot <vivien.didelot@...il.com>, Florian Fainelli <f.fainelli@...il.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Russell King <linux@...linux.org.uk>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, kernel test robot <lkp@...el.com>, Dan Carpenter <dan.carpenter@...cle.com> Subject: Re: [net-next PATCH 02/19] net: dsa: qca8k: remove redundant check in parse_port_config On Wed, Nov 17, 2021 at 10:04:34PM +0100, Ansuel Smith wrote: > The very next check for port 0 and 6 already make sure we don't go out ~~~~ makes > of bounds with the ports_config delay table. > Remove the redundant check. > > Reported-by: kernel test robot <lkp@...el.com> > Reported-by: Dan Carpenter <dan.carpenter@...cle.com> > Signed-off-by: Ansuel Smith <ansuelsmth@...il.com> > --- Reviewed-by: Vladimir Oltean <olteanv@...il.com> > drivers/net/dsa/qca8k.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c > index a429c9750add..bfffc1fb7016 100644 > --- a/drivers/net/dsa/qca8k.c > +++ b/drivers/net/dsa/qca8k.c > @@ -983,7 +983,7 @@ qca8k_parse_port_config(struct qca8k_priv *priv) > u32 delay; > > /* We have 2 CPU port. Check them */ > - for (port = 0; port < QCA8K_NUM_PORTS && cpu_port_index < QCA8K_NUM_CPU_PORTS; port++) { > + for (port = 0; port < QCA8K_NUM_PORTS; port++) { > /* Skip every other port */ > if (port != 0 && port != 6) > continue; > -- > 2.32.0 >
Powered by blists - more mailing lists