netdev - Re: [net-next PATCH 13/19] net: dsa: qca8k: add min/max ageing time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211119014911.jnfjqcqfkia7agl7@skbuf>
Date:   Fri, 19 Nov 2021 03:49:11 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Ansuel Smith <ansuelsmth@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [net-next PATCH 13/19] net: dsa: qca8k: add min/max ageing time

On Wed, Nov 17, 2021 at 10:04:45PM +0100, Ansuel Smith wrote:
> Add min and max ageing value for qca8k switch.
> 
> Signed-off-by: Ansuel Smith <ansuelsmth@...il.com>
> ---
>  drivers/net/dsa/qca8k.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
> index 50f19549b97d..dda99263fe8c 100644
> --- a/drivers/net/dsa/qca8k.c
> +++ b/drivers/net/dsa/qca8k.c
> @@ -1291,6 +1291,10 @@ qca8k_setup(struct dsa_switch *ds)
>  	/* We don't have interrupts for link changes, so we need to poll */
>  	ds->pcs_poll = true;
>  
> +	/* Set min a max ageing value supported */
> +	ds->ageing_time_min = 7000;
> +	ds->ageing_time_max = 458745000;
> +
>  	return 0;
>  }
>  
> -- 
> 2.32.0
> 

Squash with previous patch please, and you should be able to remove the
range check from qca8k_set_ageing_time.