netdev - Re: [EXT] Re: [net-next PATCH 1/2] octeontx2-pf: Add devlink param to init and de-init serdes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALHRZuqkGNRqigj1D5CBaCGvT8xcwzkparmUwUPMMDcp=UmuUQ@mail.gmail.com>
Date:   Fri, 19 Nov 2021 19:56:51 +0530
From:   sundeep subbaraya <sundeep.lkml@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Roopa Prabhu <roopa@...dia.com>, Ido Schimmel <idosch@...sch.org>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Hariprasad Kelam <hkelam@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Rakesh Babu Saladi <rsaladi2@...vell.com>,
        Saeed Mahameed <saeed@...nel.org>,
        "anthony.l.nguyen@...el.com" <anthony.l.nguyen@...el.com>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Andrew Lunn <andrew@...n.ch>, argeorge@...co.com
Subject: Re: [EXT] Re: [net-next PATCH 1/2] octeontx2-pf: Add devlink param to
 init and de-init serdes

On Fri, Nov 19, 2021 at 7:40 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Fri, 19 Nov 2021 16:17:53 +0530 sundeep subbaraya wrote:
> > As said by Ido, ndo_change_proto_down with proto_down as
> > on and off is sufficient for our requirement right now. We will use
> > ndo_change_proto_down instead of devlink. Thanks everyone for
> > pitching in.
>
> ndo_change_proto_down is for software devices. Make sure you explain
> your use case well, otherwise it's going to be a nack.

Sorry new to networking stuff here. Where does the below imply it is
for software devices?
* void (*ndo_change_proto_down)(struct net_device *dev,
 *                               bool proto_down);
 *      This function is used to pass protocol port error state information
 *      to the switch driver. The switch driver can react to the proto_down
 *      by doing a phys down on the associated switch port.
I will find out the use case (pinged customer again)

Thanks,
Sundeep