netdev - Re: [PATCH net] nfp: checking parameter process for rx-usecs/tx-usecs is invalid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211119065546.7f4d0511@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 19 Nov 2021 06:55:46 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        oss-drivers@...igine.com, Diana Wang <na.wang@...igine.com>
Subject: Re: [PATCH net] nfp: checking parameter process for
 rx-usecs/tx-usecs is invalid

On Fri, 19 Nov 2021 14:38:03 +0100 Simon Horman wrote:
> From: Diana Wang <na.wang@...igine.com>
> 
> Use nn->tlv_caps.me_freq_mhz instead of nn->me_freq_mhz to check whether
> rx-usecs/tx-usecs is valid.
> 
> This is because nn->tlv_caps.me_freq_mhz represents the clock_freq (MHz) of
> the flow processing cores (FPC) on the NIC. While nn->me_freq_mhz is not
> be set.
> 
> Fixes: ce991ab6662a ("nfp: read ME frequency from vNIC ctrl memory")
> Signed-off-by: Diana Wang <na.wang@...igine.com>
> Signed-off-by: Simon Horman <simon.horman@...igine.com>

Reviewed-by: Jakub Kicinski <kuba@...nel.org>