netdev - RE: [PATCH v4 03/10] flow_offload: add index to flow_action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 Nov 2021 07:03:53 +0000
From:   Baowen Zheng <baowen.zheng@...igine.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        Simon Horman <simon.horman@...igine.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Ido Schimmel <idosch@...dia.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>, Oz Shlomo <ozsh@...dia.com>,
        Roi Dayan <roid@...dia.com>, Vlad Buslov <vladbu@...dia.com>,
        Louis Peens <louis.peens@...igine.com>,
        oss-drivers <oss-drivers@...igine.com>
Subject: RE: [PATCH v4 03/10] flow_offload: add index to flow_action_entry
 structure

Thanks Jakub for bring this to us.
On November 19, 2021 2:31 PM, Jakub Kicinski wrote:
>On Thu, 18 Nov 2021 14:07:58 +0100 Simon Horman wrote:
>> From: Baowen Zheng <baowen.zheng@...igine.com>
>>
>> Add index to flow_action_entry structure and delete index from police
>> and gate child structure.
>>
>> We make this change to offload tc action for driver to identify a tc
>> action.
>>
>> Signed-off-by: Baowen Zheng <baowen.zheng@...igine.com>
>> Signed-off-by: Simon Horman <simon.horman@...igine.com>
>
>drivers/net/ethernet/mscc/ocelot_flower.c:306:43: error: ‘const struct
><anonymous>’ has no member named ‘index’
>  306 |                         pol_ix = a->police.index + ocelot->vcap_pol.base;
>      |                                           ^
Thanks, this new change was delivered yesterday and our patch broke it.  We will make the change in the V5 patches.