netdev - Re: [PATCH v2 02/14] net: wwan: t7xx: Add control DMA interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZdgQpiPZo2Xp1pB@smile.fi.intel.com>
Date:   Fri, 19 Nov 2021 10:28:50 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     "Martinez, Ricardo" <ricardo.martinez@...ux.intel.com>
Cc:     netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
        kuba@...nel.org, davem@...emloft.net, johannes@...solutions.net,
        ryazanov.s.a@...il.com, loic.poulain@...aro.org,
        m.chetan.kumar@...el.com, chandrashekar.devegowda@...el.com,
        linuxwwan@...el.com, chiranjeevi.rapolu@...ux.intel.com,
        haijun.liu@...iatek.com, amir.hanania@...el.com,
        dinesh.sharma@...el.com, eliot.lee@...el.com,
        mika.westerberg@...ux.intel.com, moises.veleta@...el.com,
        pierre-louis.bossart@...el.com, muralidharan.sethuraman@...el.com,
        Soumya.Prakash.Mishra@...el.com, sreehari.kancharla@...el.com,
        suresh.nagaraj@...el.com
Subject: Re: [PATCH v2 02/14] net: wwan: t7xx: Add control DMA interface

On Thu, Nov 18, 2021 at 10:36:32PM -0800, Martinez, Ricardo wrote:
> On 11/1/2021 7:03 AM, Andy Shevchenko wrote:
> > On Sun, Oct 31, 2021 at 08:56:23PM -0700, Ricardo Martinez wrote:

...

> > > +		ret = cldma_gpd_rx_from_queue(queue, budget, &over_budget);
> > > +		if (ret == -ENODATA)
> > > +			return 0;
> > > +
> > > +		if (ret)
> > > +			return ret;
> > Drop redundant blank line
> 
> The style followed is to keep a blank line after 'if' blocks.
> 
> Is that acceptable as long as it is consistent across the driver?

The idea behind suggestion is that you check for value returned from the call.
So, both if:s are tighten to that call and can be considered as a whole.

It doesn't mean you should blindly remove blank lines everywhere.

...

> > > +exit:
> > Seems useless.
> 
> This tag is used when the PM patch is introduced later in the same series.

Can you give it better name?

> > +	return ret;

-- 
With Best Regards,
Andy Shevchenko