netdev - Re: [net 10/10] net/mlx5e: Do synchronize_net only once when deactivating channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 19 Nov 2021 20:03:30 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Lama Kayal <lkayal@...dia.com>,
        Maxim Mikityanskiy <maximmi@...dia.com>,
        Tariq Toukan <tariqt@...dia.com>,
        Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [net 10/10] net/mlx5e: Do synchronize_net only once when
 deactivating channels

On Fri, 19 Nov 2021 11:58:13 -0800 Saeed Mahameed wrote:
> Synchronize_net takes time, and given that it's called multiple times
> per channel on deactivation, it accumulates to a significant amount,
> which causes timeouts in some applications (for example, when using
> bonding with NetworkManager).
> 
> This commit fixes the timing issue by restructuring the code, so that
> synchronize_net is only called once per deactivation of all channels.
> It's entirely valid, because we only need one synchronization point with
> NAPI between deactivation and closing the channels.

Since you're pushing this as a fix can we please see the benchmarks
/ numbers to justify this? The patch in Fixes was in tree for 1.5yrs.