netdev - Re: [net-next PATCH 18/19] net: dsa: qca8k: use device_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211121180359.6botb2ttg52tm5e7@skbuf>
Date:   Sun, 21 Nov 2021 20:03:59 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Ansuel Smith <ansuelsmth@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [net-next PATCH 18/19] net: dsa: qca8k: use
 device_get_match_data instead of the OF variant

On Fri, Nov 19, 2021 at 03:32:06AM +0100, Ansuel Smith wrote:
> On Fri, Nov 19, 2021 at 04:21:36AM +0200, Vladimir Oltean wrote:
> > On Wed, Nov 17, 2021 at 10:04:50PM +0100, Ansuel Smith wrote:
> > > Drop of_platform include and device_get_match_data instead of the OF
> > > variant.
> > > 
> > > Signed-off-by: Ansuel Smith <ansuelsmth@...il.com>
> > > ---
> > 
> > Why? Any ACPI device coming?
> 
> No ACPI device coming. Notice we could drop an extra include.
> Is using device API wrong for OF only drivers?
> Just asking will drop if it can cause any problem or confusion.

No problem, just that this patch is a bit weak on the justification side.
People usually don't make changes just for the fun of it.